Objective

We want to write an indicator which can draw all our history trades from current account to chart. This indicator will draw EURUSD History Trades to EURUSD Chart, it will filter Symbols automatically. Beside this you can filter trades by their MAGICNUMBER or/and Comments (by Input parameters). filterMAGIC input parameters needs to be -1 if you want include all trades. filterComment needs to be empty string to include all trades, otherwise specifify substring of comment or Magicnumber of trades you want to have displayed

Screenshoots

Source code

Basic MQL Code is:

#property copyright "Fx1 Inc, 2015"
#property link      "Fx1.net"
#property version   "1.00"
#property strict
#property indicator_chart_window

extern   int      filterMAGIC=-1; 
extern   string   filterComment="";
extern   color    BuyColor = Gold;
extern   color    SellColor = Tomato;

int   OnInit() { ObjectsDeleteAll(0,0,OBJ_TREND);   return(INIT_SUCCEEDED);  }
void  OnDeinit(const int reason)  { ObjectsDeleteAll(0,0,OBJ_TREND); }

int LastBar=-1;

int OnCalculate(const int rates_total,
                const int prev_calculated,
                const datetime &time[],
                const double &open[],
                const double &high[],
                const double &low[],
                const double &close[],
                const long &tick_volume[],
                const long &volume[],
                const int &spread[])
  {

   if (Time[1]!=LastBar)
   {
      for(int i=0;i<OrdersHistoryTotal();i++)
         {
         if (OrderSelect(i,SELECT_BY_POS,MODE_HISTORY))
         if (OrderSymbol()==Symbol())
         if (filterMAGIC<0 || OrderMagicNumber()==filterMAGIC)
         if (filterComment=="" || StringFind(OrderComment(),filterComment)>-1)
            {
               while (!DrawTrade(OrderTicket())) {}
            }
         }
      LastBar=Time[1];      
  }

   return(rates_total);
}





bool DrawTrade(int Ticket)
{
if (OrderSelect(Ticket,SELECT_BY_TICKET,MODE_HISTORY))
     {         
      string nam="DrawnTrade_"+DoubleToStr(Ticket,0);          
      if(!ObjectCreate(0,nam,OBJ_TREND,0,OrderOpenTime(),OrderOpenPrice(),OrderCloseTime(),OrderClosePrice()))
        {            
        ObjectSet(nam, OBJPROP_RAY, 0);
        ObjectSet(nam, OBJPROP_COLOR, OrderType()==OP_BUY ? BuyColor : SellColor);
        ObjectSet(nam, OBJPROP_WIDTH, 3);            
        return(true);
        }      
        else{
        return(false);
        }    
     }
return(true);
}

This is a Metatrader4 Indicator code, simply copy&paste it into your Metaeditor as Indicator and you are done, for lazy people download it from here

Comments

This small code will give you insight about trading style. I am using this code with Investor Password on my Trading Terminal to analyse trades from friends or even myself. This feature needs to be implemented into Metatrader natively. Enjoy using it.

Requirements

We assume you use mt4gui framework, assume you understand basic concepts of this framework, if not give it a try. Mt4gui is a library which can use MQL Developers have button, checkbox, radiobox, image, label etc on their charts and capture those events such as clicked.

Requirements

There are few requirements with this approach:

1. image needs to have BITMAP (.bmp) format
2. image cannot be transparent and they will cover underlying ohlc chart, i don´t recommend huge images
3. image needs to be present inside Terminal folder where terminal.exe is inside, if you want to deploy it to your clients, you need to make sure you copy the .bmp file into terminal folder with installer software. Of course you could also tell your clients to put the .bmp file into this folder but if we assume most of clients are novice, it might end up by a mess. I recommend to use a software such as EASetup to install Metatrader clients.
4. Images does not have any events. So you cannot detect a clicked event for example

Howto

Very basic MQL code is:

#include <mt4gui2.mqh>

int hwnd,image1;

int OnInit()
{
  hwnd = WindowHandle(Symbol(),Period());	
  guiRemoveAll(hwnd);		
  image1 = guiAdd(hwnd,"image",100,100,0,0,"fx1logo.bmp");
  return(INIT_SUCCEEDED);
}

int deinit()
{
  // Very important to cleanup and remove all gui items from chart   
  if (hwnd>0) guiRemoveAll(hwnd);  
  guiCleanup(hwnd); 
  return(0);
}
  
void OnTick()
{  
 // ..... your code ....
}

Result:

Easy World

It is very easy to add images with mt4gui. You can display your logo for few seconds and then remove it with guiRemove(hwnd,image1) command simply and it is gone. The dimentions of bmp file will be applied automatically, you dont need to know the dimentions, just the location.

Lets go more advanced

Code is easier than you think

#include <mt4gui2.mqh>

int hwnd,image1,xpos=100;

int OnInit()
{
  hwnd = WindowHandle(Symbol(),Period());	
  guiRemoveAll(hwnd);		
  image1 = guiAdd(hwnd,"image",xpos,100,0,0,"train.bmp");  
  EventSetMillisecondTimer(10);
  return(INIT_SUCCEEDED);
}

int deinit()
{
  // Very important to cleanup and remove all gui items from chart   
  if (hwnd>0) guiRemoveAll(hwnd);  
  guiCleanup(hwnd); 
  return(0);
}
  
void OnTick() {  }

void OnTimer()
{  
 long width;
 if (ChartGetInteger(0,CHART_WIDTH_IN_PIXELS,0,width))
 {
   guiSetPos(hwnd,image1,xpos++,100);
   if (xpos>width) xpos=0;
 } 
}

Setup for Test

I have taken ForceIndex Indicator to get started, then submitted it to mqllock using https://mqllock.com/start/ and after several minutes i had a protected version. I have installed Protected version to my computer and applied both (protected and original to chart to see if it works after protection)

All seems to work well so far with open license. Now its time to write a test mql code like seen:

void OnTick()
{

   // Original Indicator with iCustom
   double Ret1 = iCustom(Symbol(),Period(),"ForceIndex",13,0,0,0,0);   
   // Protected Indicator with iCustom
   double Ret2 = iCustom(Symbol(),Period(),"MQLLock_5200_ForceIndex_rev1",13,0,0,0,0);
   
   // Output
   Print("Original = "+DoubleToStr(Ret1,2)+" Protected = "+DoubleToStr(Ret2,2));      
}

As you see i am calling original indicator with iCustom and Protected one with iCustom. Manual page for iCustom is very well written and worth to check.

It works!

The results are very well like seen here on output; Original called iCustom values are exactly same as Protected version:

I have tried same with Account Number Licensing, it has worked too same good. As last test i have removed the license on mqllock administration panel and restarted the Metatrader4 Terminal, it has closed the terminal with insufficient license error! All works perfectly.

Conclusion

MQLLock protected indicators applied to chart or called from iCustom works perfectly. No issues at all. All Features are compatible. Enjoy it

MT4 Terminal requires Signal Search Feature

There are around 2000 Signals in mql5.com Signal Database for MT4. Imagine you have found a “good” signal and want to subscribe to it from your terminal. You can click to Subscribe button on web and your browser will open MT4 Terminal with request to subscribe. But imagine if you have multiple MT4 Terminals installed (most of us have done) then your browser will open always same browser (usually first of last installed Terminal).

You may try to search the signal from Signals Tab inside MT4 Terminal. The problem here is that you cannot find your signal easly among thousands of signals! Metatrader4 definetly needs a search signal feature.

I have also tried to Subscribe to Signals with MQL Script. Since Build > 620 they have introduced “Trade Signal Commands”, they look very promising at first sight. I have tried following code:

void OnStart()
  {
  int total=SignalBaseTotal();
  long signalid = 74156;
//--- process all signals
   for(int i=0;i<total;i++)
     {
      //--- select the signal by index
      if(SignalBaseSelect(i))
        {
         //--- get signal properties
         long   id    =SignalBaseGetInteger(SIGNAL_BASE_ID);          // signal id
         long   pips  =SignalBaseGetInteger(SIGNAL_BASE_PIPS);        // profit in pips
         long   subscr=SignalBaseGetInteger(SIGNAL_BASE_SUBSCRIBERS); // number of subscribers
         string name  =SignalBaseGetString(SIGNAL_BASE_NAME);         // signal name
         double price =SignalBaseGetDouble(SIGNAL_BASE_PRICE);        // signal price
         //--- print all profitable free signals with subscribers
         if(price==0.0 && pips>0 && subscr>0)
            PrintFormat("id=%d, name=\"%s\", pips=%d, subscribers=%d",id,name,pips,subscr);
        }
      else PrintFormat("Error in call of SignalBaseSelect. Error code=%d",GetLastError());
     }
  ResetLastError();
  if (SignalSubscribe(signalid))
  {
   Print("Success");
  }
  else 
  {
   Print("Error : "+GetLastError());
  }
  }

Result: it throw me around 120 signals out of 2000 available. Different brokers deliver different signals. Moreover SignalSubscribe() command fails with 4060 error if you run it as Script(Operation not permitted). For more details about this problem i have opened a forum thread. Update: Signalsubscribe seems to work as Expert Advisor but i think its too insecure to be able to subscribe to signals from an Expert Advisor. To subscribe to any signal you would need to enter SignalID as external parameter and EA would subscribe for you.

Conclusion: It is not easy to subscribe in multi mt4 environment to pre-choosen signal providers feed without external tools. I really hope that Metaquotes implements search functionality into MT4.

Find SignalID

SignalID is an unique identified which is assigned to every unique signal at mql5.com site. SignalID is usually carried in URL to load signals. For example; the Signal ‘Lol’ has SignalID 47702, we can read this from url https://www.mql5.com/en/signals/47702. Of course you could use Signal Enumerating functions to find your Signal and use

long   id    =SignalBaseGetInteger(SIGNAL_BASE_ID);

to search the Identified, but as i mentioned this function is not working properly (probably not yet)

Manual Approach

You can initiate a subscription with Parameters sent to MT4 Terminal easly. Here is how:

1. Make sure your MT4 Terminal you want to start subscription is logged in with your mql5.com credentials & has enough credit on account, deposit more, if you don´t
2. You open Command Line Interface (cmd.exe)
3. Go into the folder with cd command
4. type

   terminal.exe "mql4buy://signal/subscribe/12345.fx1"

   and press Enter. You replace 12345 with your favorite SignalID.
   

5. Wait several seconds, your terminal will popup with Subscribe confirmation dialog

Automatic: SignalSubscriber

I have written small utility for myself you can type SignalID and select Terminal to subscribe and it will start subscription dialog with Terminal automatically. This tool does not automate all process, you still need to confirm subscription with your mql5.com login. You will also need a Terminal which supports Signals and enough credit.

You can download this tool here

I am using SignalSubscriber tool myself and so far very nice tool, it helps me to subscribe signals rapidly.

Hope to have helped to save you guys time & money